-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added PollResponse Through Email #108
✨ Added PollResponse Through Email #108
Conversation
Congrats and thanks! |
@PushkarDureja I'll take a look once I reach home (in couple hours). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me except the part where I've commented on
We will merge it once the endpoint is done. |
Great !! |
@PushkarDureja have you tested this PR with the new endpoint locally? If yes, we can merge this. |
Yes I did it yesterday only after adding back the |
Thanks, merging! |
We've deployed this PR to our site, so can you check out the changes and let us know if everything is fine? |
Sure, Let me check |
@anandbaburajan I don't think it is working!! Did you redeploy the mailer ? |
Yup. |
As far as I remember, It was working fine on my local environment. But give me some time to figure it out |
@AthulJoshi can you share the mailer logs with Pushkar and/or look into it? Thanks! |
senderName: newVote.name, | ||
}; | ||
sendPollResponse(mailerArgs, token); | ||
} | ||
Router.reload(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AthulJoshi I have added a comment, Please have a look |
So, the page is reloading before the request is completed right? |
But even if the request has been initiated (which is actually happening, I checked on the live one), Will it depend on the fact, whether the browser is being reloaded or not ? |
Fixes #95
I have implemented the code for sending email to the poll creator whenever someone votes on their poll