Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Auto Encoder Model and Evaluation Notebook #289

Merged
merged 10 commits into from
Feb 9, 2024
Merged

Add Auto Encoder Model and Evaluation Notebook #289

merged 10 commits into from
Feb 9, 2024

Conversation

asyatrhl
Copy link
Collaborator

@asyatrhl asyatrhl commented Feb 5, 2024

No description provided.

@rotx-eva rotx-eva marked this pull request as draft February 5, 2024 19:35
@rotx-eva rotx-eva changed the base branch from develop to voyager February 5, 2024 19:47
rotx-eva
rotx-eva suggested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@rotx-eva rotx-eva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add links to the documentation and dataset repository, and use os.path.join instead of "/" or "../" (affects both code and notebook)

datasets/samplemotordatalimerick.py Outdated Show resolved Hide resolved
notebooks/AutoEncoder_Evaluation.ipynb Show resolved Hide resolved
notebooks/AutoEncoder_Evaluation.ipynb Outdated Show resolved Hide resolved
notebooks/AutoEncoder_Evaluation.ipynb Outdated Show resolved Hide resolved
notebooks/AutoEncoder_Evaluation.ipynb Outdated Show resolved Hide resolved
@rotx-eva rotx-eva marked this pull request as ready for review February 7, 2024 14:26
asyatrhl and others added 4 commits February 7, 2024 18:25
@asyatrhl
Add dataset download function.
cad5d3e 
Update trained checkpoint name in evaluation script.
Update comments.
Remove sensor_options.
@asyatrhl
Linter fix
c06a704
@asyatrhl
Update dataloader and evaluation notebook
43d4b94
@asyatrhl
Add documentation link
668db13
@rotx-eva rotx-eva merged commit acd256f into analogdevicesinc:voyager Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotx-eva rotx-eva rotx-eva approved these changes

@seldauyanik-maxim seldauyanik-maxim seldauyanik-maxim approved these changes

@ermanok ermanok Awaiting requested review from ermanok

@MaximGorkem MaximGorkem Awaiting requested review from MaximGorkem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asyatrhl @rotx-eva @seldauyanik-maxim