Skip to content

Wrap exceptions in HttpRequestException #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Wrap exceptions in HttpRequestException #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcf85a9
Wrap exceptions in HttpRequestException
Alxandr Dec 28, 2014
ec26be9
Only catch IOExceptions
Alxandr Dec 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/ModernHttpClient/Android/OkHttpNetworkHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Security.Cryptography.X509Certificates;
using System.Globalization;
using Android.OS;
using Java.Net;

namespace ModernHttpClient
{
Expand Down Expand Up @@ -113,12 +114,16 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
throw new CaptiveNetworkException(new Uri(java_uri), new Uri(newUri.ToString()));
}
}
} catch (UnknownHostException ex) {
throw new HttpRequestException("Unknown host", ex);
} catch (IOException ex) {
if (ex.Message.ToLowerInvariant().Contains("canceled")) {
throw new OperationCanceledException();
throw new OperationCanceledException(ex.Message, ex);
}

throw;
throw new HttpRequestException(
ex.Message,
ex);
}

var respBody = resp.Body();
Expand Down