Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: generate directory if path not exist in compile_mmap_model #281

Merged
merged 1 commit into from
Feb 23, 2024
Merged

bug fix: generate directory if path not exist in compile_mmap_model #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pecos/xmc/xlinear/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ def save(self, model_folder):
Args:
model_folder (str): dir to save the model
"""
if not path.exists(model_folder):
os.makedirs(model_folder)

os.makedirs(model_folder, exist_ok=True)
param = self.append_meta({})
with open(f"{model_folder}/param.json", "w", encoding="utf-8") as fout:
fout.write(json.dumps(param, indent=True))
Expand Down Expand Up @@ -144,6 +144,7 @@ def compile_mmap_model(cls, npz_folder, mmap_folder):
"""
import shutil

os.makedirs(mmap_folder, exist_ok=True)
shutil.copyfile(path.join(npz_folder, "param.json"), path.join(mmap_folder, "param.json"))
HierarchicalMLModel.compile_mmap_model(
path.join(npz_folder, "ranker"), path.join(mmap_folder, "ranker")
Expand Down
2 changes: 0 additions & 2 deletions test/pecos/xmc/xlinear/test_xlinear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,6 @@ def test_on_model(model, X):


def test_mmap(tmpdir):
from pathlib import Path
from pecos.utils import smat_util
from pecos.xmc.xlinear import XLinearModel
from pecos.xmc import PostProcessor
Expand All @@ -1153,7 +1152,6 @@ def test_mmap(tmpdir):

npz_model_folder = str(tmpdir.join("save_model_npz"))
mmap_model_folder = str(tmpdir.join("save_model_mmap"))
Path(mmap_model_folder).mkdir(parents=True, exist_ok=True)
py_model.save(npz_model_folder)
XLinearModel.compile_mmap_model(npz_model_folder, mmap_model_folder)
mmap_model = XLinearModel.load(mmap_model_folder, is_predict_only=True)
Expand Down
Loading