Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin build-pypi-wheel runner image to ubuntu-20.04 #188

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

weiliw-amz
Copy link
Contributor

As of Nov 9th, Github is experimenting with transitioning ubuntu-latest label to the Ubuntu 22.04 runner image. "During the transition, the label might refer to the runner image for either Ubuntu 20.04 or 22.04." which means if we get lucky, our build_pypi action will run on ubuntu-22.04-enabled runner and that will definitely fail python3.6 sub-job since it is not prebuilt by GitHub therefore not available with Github action setup-python for the new ubuntu 22.04.

More information: https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/

Ubuntu-18.04 is marked as deprecated and will be moved out of Github runner in the future, see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources. Moreover, the Python version is also slowly migrating towards 3.10 and deprecating 3.6, which PECOS future supported versions might be aware of and we will hold a discussion and PR to upgrade in the future.

Issue #, if available:
N/A

Description of changes:
Changed build-pypi action to run on ubuntu-20.04

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

As of Nov 9th, Github is experimenting with  transitioning `ubuntu-latest` label  to the Ubuntu 22.04 runner image. "During the transition, the label might refer to the runner image for either Ubuntu 20.04 or 22.04." which means if we get **lucky**, our `build_pypi` action will run on `ubuntu-22.04`-enabled runner and that will definitely fail `python3.6` sub-job since it is not prebuilt by GitHub therefore not available with Github action `setup-python` for the new ubuntu 22.04.

More information: https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/

Ubuntu-18.04 is marked as deprecated and will be moved out of Github runner in the future, see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources. Moreover, the Python version is also slowly migrating towards 3.10 and deprecating 3.6, which PECOS future supported versions might be aware of and we will hold a discussion and PR to upgrade in the future.
@weiliw-amz weiliw-amz requested a review from yaushian December 3, 2022 01:26
@weiliw-amz weiliw-amz self-assigned this Dec 3, 2022
@yaushian yaushian merged commit 2f0eee5 into mainline Dec 3, 2022
@weiliw-amz weiliw-amz deleted the weiliw-amz-pin-build-pypi-ubuntu-20.04 branch December 7, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants