Skip to content

Image processor mixin#25

Merged
amyeroberts merged 15 commits intoimage-transforms-libraryfrom
image-processor-mixin
Aug 16, 2022
Merged

Image processor mixin#25
amyeroberts merged 15 commits intoimage-transforms-libraryfrom
image-processor-mixin

Conversation

@amyeroberts
Copy link
Owner

What does this PR do?

This is part of a series of PRs to introduce the ImageProcessor class for vision models.

Adds an alias for the FeatureProcessorMixin as ImageProcessorMixin. This mixin provides the saving/loading functionality for the processing classes. Much of the logic will be exactly the same between the two, and so a more general class is needed for feature extractors and image processors. Otherwise we are likely to have confusing inheritance in the code e.g. class XxxImageProcessor(FeatureExtractorMixin.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 8, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@alaradirik alaradirik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@amyeroberts amyeroberts merged commit cb1dcd8 into image-transforms-library Aug 16, 2022
@amyeroberts amyeroberts deleted the image-processor-mixin branch August 16, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants