Type cast before normalize mobilevit#21
Merged
amyeroberts merged 3 commits intotype-cast-before-normalize-update-methodsfrom Sep 2, 2022
Merged
Conversation
…th different configs
…st-before-normalize-mobilevit
|
The documentation is not available anymore as the PR was closed or merged. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modifies the feature extractor call to make the inputs to
BatchFeaturealways numpy arrays. This ensures the type of the returnedpixel_valuesmatches those requested withreturn_tensors. The conversion to numpy arrays happens before normalization to ensure consistent rescaling is done on the inputs.This solution means the
return_tensors=Nonedefault can stay and that the behaviour is as expected for any combination of thedo_xxxflag values.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.