Impr/add enums #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description This MR adds benchmarks to this package using golang's benchmarking tool, making it easier to compare and contrast the differences in speed. This replaces the benchmarks in measurements.go as it provides a cleaner output.
## Description This MR makes use of go generics which provides a level of error checking since we can now put constraints on our interfaces. Example, we can limit our map keys to comparable values.
## Description This changes the use of raw strings to enums. With this users aware of their algorithm options and can choose between them without having to guess which ones have been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the use of raw strings to enums. With this users aware of
their algorithm options and can choose between them without having to
guess which ones have been implemented.