Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations test. #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Annotations test. #6

wants to merge 4 commits into from

Conversation

amscanne
Copy link
Owner

Do annotations show up in code review?

@amscanne @gvisor-bot
Add nogo check annotations to GitHub.
503c778 
When nogo checks are violated, they will automatically posted
as annotations on the specific GitHub commit. This allows us
to ensure analysis & style rules and have them called out.

PiperOrigin-RevId: 333667992
@amscanne
Add illegal import.
40bcda2
@amscanne
Fast-forward.
d662c57
@amscanne
Add violation.
a9bb376
@amscanne
Copy link
Owner Author

Comment test.

@amscanne
Copy link
Owner Author

Another comment test.

@amscanne
Copy link
Owner Author

Test comment.

@amscanne
Copy link
Owner Author

Test.

1 similar comment
@amscanne
Copy link
Owner Author

Test.

@amscanne
Copy link
Owner Author

Test

2 similar comments
@amscanne
Copy link
Owner Author

Test

@amscanne
Copy link
Owner Author

Test

@amscanne amscanne force-pushed the master branch 2 times, most recently from aaa7e2d to 387e540 Compare November 23, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amscanne