replace httr::GET() with httr::RETRY() #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
===========================================
- Coverage 80.00% 66.66% -13.34%
===========================================
Files 1 1
Lines 50 48 -2
===========================================
- Hits 40 32 -8
- Misses 10 16 +6
Continue to review full report at Codecov.
|
|
Thanks for this PR, seems valid! I've not seen this kind of initiative from other R conferences. Is it some kind of contest? |
|
@amrrs The conference had a talk/project about the topic and we broke out to find and fix this potential issue across httr packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for for this awesome project, @amrrs ! I'm working on chircollab/chircollab20#1 as part of Chicago R Collab.
In this PR, I'd like to propose swapping out calls to httr::GET() with httr::RETRY(). This will make the package more resilient to transient problems like brief network outages or periods where the service(s) it hits are overwhelmed. In my experience, using retry logic almost always improves the user experience with HTTP clients.