Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerPatch - Fix default bloom #96

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

Balimbanana
Copy link
Contributor

  • r_bloomint* convars are not being set correctly on the client if they join a server by steam://connect links or launching with -dev skipping map_background. The issue stems from having several configuration ConVars in skill.cfg which is not executed unless a background or regular map is loaded first client-side. There may be more ConVars that need to be fixed, but this one is glaring. It is implemented using QueryClientConVar and ClientCommand because these ConVars do not have FCVAR_REPLICATED applied.

- r_bloomint* convars are not being set correctly on the client if they join a server by steam://connect links or launching with -dev skipping map_background.
The issue stems from having several configuration ConVars in skill.cfg which is not executed unless a background or regular map is loaded first client-side.
There may be more ConVars that need to be fixed, but this one is glaring.
It is implemented using QueryClientConVar and ClientCommand because these ConVars do not have FCVAR_REPLICATED applied.
- Normally 0.8 by cfg, but if skipped will be 2.5 which is a bit too bright.
@Alienmario
Copy link
Collaborator

Alienmario commented May 13, 2023

Was able to try the commands out.
This does concern joining via Steam server browser too.
For bloom I didn't see any difference, but that could be my settings.
Personally I prefer the brighter flashlight, would preferably get some feedback first.

@Balimbanana
Copy link
Contributor Author

The bloom greatly affects certain lights like spot lights:
image

If you start bm_c1a0b you can see the effect of changing those bloom CVars.

The CVar resets are only if you are using the default values, so if you had your flashlight set brighter than default, it won't reset for you.

@Alienmario
Copy link
Collaborator

Still nothing.
20230514032820_1

@Balimbanana
Copy link
Contributor Author

Do you have color correction off or any other settings changed from default already? I noticed that there is no glow around the health counter on the bottom left either for you.

@Alienmario
Copy link
Collaborator

Looks like bloom never worked for me. Can't figure it out, so let's just say it's an AMD thing.

@Alienmario Alienmario merged commit 3ec2601 into ampreeT:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants