Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Singleplayer DMX values #182

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Load Singleplayer DMX values #182

merged 3 commits into from
Nov 26, 2024

Conversation

ampreeT
Copy link
Owner

@ampreeT ampreeT commented Nov 26, 2024

This forces the game to reload the weapon parameters on level initialization and to use singleplayer values in a cooperative map.

Fixes some issues in #144.

Notable Changes:

  • Crowbar's attack speed is now same as singleplayer
  • MP5 clip size now uses singleplayer values (45 to 30)
  • Weapon damage values now matches singleplayer values

@ampreeT ampreeT requested a review from Alienmario November 26, 2024 06:01
Copy link
Collaborator

@Alienmario Alienmario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are there any prediction issues?

@ampreeT
Copy link
Owner Author

ampreeT commented Nov 26, 2024

LGTM. Are there any prediction issues?

The only prediction issue that I have found is holding the reload button while the MP5's clip size is full at 30. The client still thinks that the MP5 clip size is still 45.

@ampreeT ampreeT merged commit 8dbd8a4 into master Nov 26, 2024
2 checks passed
@ampreeT ampreeT deleted the sp-dmx-values branch November 26, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants