Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levellump #134

Merged
merged 6 commits into from
Jul 13, 2024
Merged

Levellump #134

merged 6 commits into from
Jul 13, 2024

Conversation

Alienmario
Copy link
Collaborator

@Alienmario Alienmario commented Jul 10, 2024

This PR cleans up the levellump subsystem, adding comments, logs, optimizations and some breaking changes and fixing scarce bugs.

  • Separation of entity property modification actions: add, set, replace
    • Add will no longer check for duplicate properties
    • Set will update or create an entity property if missing, never adding duplicates (preserved behavior)
    • Replace will only update existing properties
  • Entity property deletion (entity->modify->delete)
    • Added value matching for non-empty values
    • To keep matching properties for deletion by keys only, the value has to stay blank ""
  • This distinction is done primarily to enhance convertibility between Stripper:source scripts

This shall remain open until all edt scripts are corrected.

- comments, cleanup
- separation of entity modify actions: add, set, replace
- added value matching for non-empty values inside entity->modify->delete blocks
@Alienmario Alienmario marked this pull request as ready for review July 10, 2024 15:53
@Alienmario Alienmario requested a review from ampreeT July 10, 2024 15:54
@ampreeT
Copy link
Owner

ampreeT commented Jul 13, 2024

Looks good to me! Good job on adding docs where it was missing. We're going to have to test the campaign just to make sure nothing broke.

@Alienmario Alienmario merged commit caffc21 into master Jul 13, 2024
4 checks passed
@Alienmario Alienmario deleted the levellump branch July 13, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants