Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify param naming - data-param #7958

Merged
1 commit merged into from Mar 3, 2017
Merged

Clarify param naming - data-param #7958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions extensions/amp-social-share/amp-social-share.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,23 +94,24 @@ The `amp-social-share` component provides [some pre-configured providers](0.1/am
<td>Email</td>
<td>
<ul>
<li><code>subject</code>: optional, defaults to: Current page title</li>
<li><code>body</code>: optional, defaults to: <code>rel=canonical</code> URL</li></ul>
<li><code>data-param-subject</code>: optional, defaults to: Current page title</li>
<li><code>data-param-body</code>: optional, defaults to: <code>rel=canonical</code> URL</li></ul>
</td>
</tr>
<tr>
<td>Facebook</td>
<td>
<ul>
<li><code>href</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>app_id</code>: required, defaults to: none. This parameter is required for the <a href="https://developers.facebook.com/docs/sharing/reference/share-dialog">Facebook Share dialog</a>.</li></ul>
<li><code>data-param-app_id</code>: <strong>required</strong>, defaults to: none. This parameter is required for the <a href="https://developers.facebook.com/docs/sharing/reference/share-dialog">Facebook Share dialog</a>.</li>
<li><code>data-param-href</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
</ul>
</td>
</tr>
<tr>
<td>LinkedIn</td>
<td>
<ul>
<li><code>url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>data-param-url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
</ul>
</td>
</tr>
Expand All @@ -119,8 +120,8 @@ The `amp-social-share` component provides [some pre-configured providers](0.1/am
<td>Pinterest</td>
<td>
<ul>
<li><code>url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>description</code>: optional, defaults to: Current page title</li>
<li><code>data-param-url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>data-param-description</code>: optional, defaults to: Current page title</li>
</ul>
</td>
</tr>
Expand All @@ -129,42 +130,42 @@ The `amp-social-share` component provides [some pre-configured providers](0.1/am
<td>G+</td>
<td>
<ul>
<li><code>url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>data-param-url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
</ul>
</td>
</tr>
<tr>
<td>Tumblr</td>
<td>
<ul>
<li><code>url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>text</code>: optional, defaults to: Current page title</li>
<li><code>data-param-url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>data-param-text</code>: optional, defaults to: Current page title</li>
</ul>
</td>
</tr>
<tr>
<td>Twitter</td>
<td>
<ul>
<li><code>url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>text</code>: optional, defaults to: Current page title</li>
<li><code>data-param-url</code>: optional, defaults to: <code>rel=canonical</code> URL</li>
<li><code>data-param-text</code>: optional, defaults to: Current page title</li>
</ul>
</td>
</tr>
<tr>
<td>Whatsapp</td>
<td>
<ul>
<li><code>text</code>: optional, defaults to: "Current page title - current page URL"</li>
<li><code>data-param-text</code>: optional, defaults to: "Current page title - current page URL"</li>
</ul>
</td>
</tr>
<tr>
<td><a href="https://developers.google.com/web/updates/2016/10/navigator-share">Web Share API</a> (available in Chrome as an <a href="https://github.com/jpchase/OriginTrials/blob/gh-pages/developer-guide.md">origin trial</a>)</td>
<td>
<ul>
<li><code>text</code>: optional, defaults to: "Current page title"</li>
<li><code>data-mode</code>: optional, if set to <code>replace</code>, all other share options are removed.</li>
<li><code>data-param-text</code>: optional, defaults to: "Current page title"</li>
<li><code>data-param-data-mode</code>: optional, if set to <code>replace</code>, all other share options are removed.</li>
</ul>
</td>
</tr>
Expand Down