Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Registration: Extensions #7858

Merged
merged 32 commits into from
Mar 21, 2017

Conversation

kmh287
Copy link
Contributor

@kmh287 kmh287 commented Mar 1, 2017

This pull request distinguishes installing/registering the extensions service and creating it.Please see #7839 for more context.

/to @choumx @jridgewell

@kmh287 kmh287 force-pushed the service_registration3_extensions branch from 81c9ef6 to 6081e24 Compare March 7, 2017 14:35
@kmh287 kmh287 force-pushed the service_registration3_extensions branch from 7f4d65e to b0a7d2f Compare March 7, 2017 15:15
@ampprojectbot
Copy link
Member

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to cramforce dvoytenko

  • testing/describes.js

/to ampproject/a4a

  • ads/google/a4a/test/test-utils.js

/to ampproject/a4a

  • extensions/amp-ad-network-adsense-impl/0.1/test/test-amp-ad-network-adsense-impl.js

/to ampproject/a4a

  • extensions/amp-ad-network-doubleclick-impl/0.1/test/test-amp-ad-network-doubleclick-impl.js

/to dvoytenko jridgewell

  • src/extensions.js
  • src/runtime.js
  • src/service/extensions-impl.js

/to aghassemi alanorozco camelburrito chenshay choumx cramforce cvializ dvoytenko ericlindley-g erwinmombay gregable honeybadgerdontcare jridgewell kmh287 lannka mkhatib mrjoro muxin newmuis powdercloud zhouyx

  • test/functional/test-cid.js
  • test/functional/test-crypto.js
  • test/functional/test-extensions.js
  • test/functional/test-runtime.js

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

@kmh287 kmh287 force-pushed the service_registration3_extensions branch from 1c869d1 to c3b71b3 Compare March 16, 2017 17:19
@ampprojectbot
Copy link
Member

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to cramforce dvoytenko jridgewell

  • testing/describes.js

/to ampproject/a4a

  • ads/google/a4a/test/test-utils.js

/to ampproject/a4a

  • extensions/amp-ad-network-adsense-impl/0.1/test/test-amp-ad-network-adsense-impl.js

/to ampproject/a4a

  • extensions/amp-ad-network-doubleclick-impl/0.1/test/test-amp-ad-network-doubleclick-impl.js

/to dvoytenko jridgewell

  • src/extensions.js
  • src/runtime.js
  • src/service/extensions-impl.js

/to alanorozco camelburrito chenshay choumx cramforce cvializ dvoytenko ericlindley-g erwinmombay gregable honeybadgerdontcare jridgewell kmh287 lannka mkhatib mrjoro muxin newmuis powdercloud zhouyx

  • test/functional/test-cid.js
  • test/functional/test-crypto.js
  • test/functional/test-extensions.js
  • test/functional/test-runtime.js

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

@ampprojectbot
Copy link
Member

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to cramforce dvoytenko jridgewell

  • testing/describes.js

/to ampproject/a4a

  • ads/google/a4a/test/test-utils.js

/to ampproject/a4a

  • extensions/amp-ad-network-adsense-impl/0.1/test/test-amp-ad-network-adsense-impl.js

/to ampproject/a4a

  • extensions/amp-ad-network-doubleclick-impl/0.1/test/test-amp-ad-network-doubleclick-impl.js

/to dvoytenko jridgewell

  • src/extensions.js
  • src/runtime.js
  • src/service/extensions-impl.js

/to alanorozco camelburrito chenshay choumx cvializ ericlindley-g erwinmombay gregable honeybadgerdontcare jridgewell kmh287 lannka mkhatib mrjoro muxin newmuis powdercloud zhouyx

  • test/functional/test-cid.js
  • test/functional/test-crypto.js
  • test/functional/test-extensions.js
  • test/functional/test-runtime.js

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

@kmh287 kmh287 merged commit af1d656 into ampproject:master Mar 21, 2017
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants