Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Update dependency chromedriver to v130 #39912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 21, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
chromedriver 119.0.1 -> 130.0.0 age adoption passing confidence

See all other Renovate PRs on the Dependency Dashboard

How to resolve breaking changes

This PR may introduce breaking changes that require manual intervention. In such cases, you will need to check out this branch, fix the cause of the breakage, and commit the fix to ensure a green CI build. To check out and update this PR, follow the steps below:

# Check out the PR branch
git checkout -b renovate/major-chrome-and-chromedriver main
git pull https://github.com/ampproject/amphtml.git renovate/major-chrome-and-chromedriver

# Directly make fixes and commit them
amp lint --fix # For lint errors in JS files
amp prettify --fix # For prettier errors in non-JS files
# Edit source code in case of new compiler warnings / errors

# Push the changes to the branch
git push [email protected]:ampproject/amphtml.git renovate/major-chrome-and-chromedriver:renovate/major-chrome-and-chromedriver

Release Notes

giggio/node-chromedriver (chromedriver)

v130.0.0

Compare Source

v129.0.4

Compare Source

v129.0.3

Compare Source

v129.0.2

Compare Source

v129.0.1

Compare Source

v129.0.0

Compare Source

v128.0.3

Compare Source

v128.0.2

Compare Source

v128.0.1

Compare Source

v128.0.0

Compare Source

v127.0.3

Compare Source

v127.0.2

Compare Source

v127.0.1

Compare Source

v127.0.0

Compare Source

v126.0.5

Compare Source

v126.0.4

Compare Source

v126.0.3

Compare Source

v126.0.2

Compare Source

v126.0.1

Compare Source

v126.0.0

Compare Source

v125.0.3

Compare Source

v125.0.2

Compare Source

v125.0.1

Compare Source

v125.0.0

Compare Source

v124.0.4

Compare Source

v124.0.3

Compare Source

v124.0.2

Compare Source

v124.0.1

Compare Source

v124.0.0

Compare Source

v123.0.4

Compare Source

v123.0.3

Compare Source

v123.0.2

Compare Source

v123.0.1

Compare Source

v123.0.0

Compare Source

v122.0.6

Compare Source

v122.0.5

Compare Source

v122.0.4

Compare Source

v122.0.3

Compare Source

v122.0.2

Compare Source

v122.0.1

Compare Source

v122.0.0

Compare Source

v121.0.2

Compare Source

v121.0.1

Compare Source

v121.0.0

Compare Source

v120.0.2

Compare Source

v120.0.1

Compare Source

v120.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "after 12am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the WG: infra label Mar 21, 2024
@renovate renovate bot enabled auto-merge (squash) March 21, 2024 13:45
@danielrozenberg
Copy link
Member

Looks like there was a change in Chrome that breaks some of these tests. The breakage results from a difference here:

https://github.com/ampproject/amphtml/blob/main/extensions/amp-skimlinks/0.1/test/helpers.js#L13-L18

In Chrome 119, creating an <a> element inside the FakeWindow's Document, then setting its anchor.href to a schema-agnostic URL (e.g., anchor.href = '//a.com/';, ancho.href = 'a.com';) correctly changes the anchor.hostname field as well.

In Chrome 120, these URLs result in an empty string in anchor.hostname.

This issue only manifests itself inside the FakeWindow, it works as expected in a real window.

The one thing I noticed is that win.document.baseURI is set to http://localhost:6789/path/to/test/file.html in 119, and to about:blank in 120. I'm not sure if this is relevant, or how to continue this investigation

Help! @ychsieh @erwinmombay

@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 2 times, most recently from e0725cf to 0a489f1 Compare April 15, 2024 18:09
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 0a489f1 to 5148c80 Compare April 18, 2024 17:34
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 5148c80 to ce8cc26 Compare April 26, 2024 17:43
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v123 📦 Update dependency chromedriver to v124 Apr 26, 2024
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 3 times, most recently from d290820 to 1ffe664 Compare May 6, 2024 15:50
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 2 times, most recently from 2831a06 to c467835 Compare May 14, 2024 16:09
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from c467835 to e8da64f Compare May 20, 2024 18:11
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v124 📦 Update dependency chromedriver to v125 May 20, 2024
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 2 times, most recently from 75e1661 to 950eb01 Compare June 3, 2024 19:10
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 2 times, most recently from 9d99897 to 14f7dfa Compare June 11, 2024 17:28
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 14f7dfa to 23aecd4 Compare June 13, 2024 13:17
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v125 📦 Update dependency chromedriver to v126 Jun 13, 2024
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 3 times, most recently from c39a894 to fecc3f2 Compare June 26, 2024 16:04
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v126 📦 Update dependency chromedriver to v126 - autoclosed Jun 27, 2024
@renovate renovate bot closed this Jun 27, 2024
auto-merge was automatically disabled June 27, 2024 09:51

Pull request was closed

@renovate renovate bot deleted the renovate/major-chrome-and-chromedriver branch June 27, 2024 09:51
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v126 - autoclosed 📦 Update dependency chromedriver to v126 Jun 27, 2024
@renovate renovate bot restored the renovate/major-chrome-and-chromedriver branch June 27, 2024 18:52
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from fecc3f2 to 61a1fdc Compare July 8, 2024 19:31
@renovate renovate bot enabled auto-merge (squash) July 8, 2024 19:31
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 2 times, most recently from de669f2 to 9f79adc Compare July 11, 2024 16:57
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v126 📦 Update dependency chromedriver to v127 Aug 6, 2024
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 3 times, most recently from 3b184c1 to 9c7fa44 Compare August 12, 2024 17:03
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 9c7fa44 to fef2c68 Compare August 27, 2024 10:40
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v127 📦 Update dependency chromedriver to v128 Aug 27, 2024
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 3 times, most recently from 07e06cd to 3ca1f57 Compare September 9, 2024 16:16
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 3ca1f57 to 94a0c3c Compare September 16, 2024 16:23
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v128 📦 Update dependency chromedriver to v129 Sep 23, 2024
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 4 times, most recently from d9f74c4 to c2e3544 Compare September 27, 2024 16:12
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch 4 times, most recently from 464941b to 6a18b90 Compare October 4, 2024 16:54
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 6a18b90 to 5a84bc8 Compare October 8, 2024 15:28
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 5a84bc8 to 1a1553f Compare October 16, 2024 17:42
@renovate renovate bot changed the title 📦 Update dependency chromedriver to v129 📦 Update dependency chromedriver to v130 Oct 16, 2024
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 1a1553f to 87fb8f3 Compare October 18, 2024 00:11
@renovate renovate bot force-pushed the renovate/major-chrome-and-chromedriver branch from 87fb8f3 to 191646f Compare October 20, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant