chore(karma): add bundleDelay option to karma config
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should fix #26 /cc @cramforce |
|
side note, after all the repeated running of tests i seem to run into the problem below consistently (image below) where the tests just start failing. (i didn't change anything, i just keep on pressing save and it starts failing at some point. seems to be a history issue of some sort)
|
|
The history test is definitely flaky. @dvoytenko But this is a great step forward!!! Being able to run tests consistently helps with fixing flaky tests. To be honest, I'm surprised they even work as well as they do now. |
cramforce
added a commit
that referenced
this pull request
Sep 9, 2015
chore(karma): add `bundleDelay` option to karma config
Closed
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a
bundleDelayoption. seems to fix the issue where karma stops running. will need more people to test it out but from my initial tests (i kept on refreshing the test by pressing save every time it finished) it seems to be working fine now.references:
nikku/karma-browserify#140
https://github.com/nikku/karma-browserify (bundleDelay option)