Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added optional product-tag-text for amp story shopping tag #37112

Merged
merged 8 commits into from
Dec 7, 2021
Merged

✨ Added optional product-tag-text for amp story shopping tag #37112

merged 8 commits into from
Dec 7, 2021

Conversation

jshamble
Copy link
Contributor

@jshamble jshamble commented Dec 4, 2021

Adds an optional parameter which allows you to use the product tag text instead of the displayed price.
closes #37105

@jshamble jshamble requested review from processprocess and removed request for mszylkowski December 4, 2021 06:09
@amp-owners-bot
Copy link

amp-owners-bot bot commented Dec 4, 2021 •
edited
Loading

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-tag.css
extensions/amp-story-shopping/0.1/amp-story-shopping-tag.js
extensions/amp-story/1.0/amp-story-store-service.js

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-store-service.js

@processprocess
Copy link
Contributor

Nice! Please update the visual diff test for this.
Please update the name of this PR. We don't currently have anything named optProdTagText.

We need to aim for our PR titles to be understandable.
You and I have context on this but please keep in mind that others do not.

@processprocess processprocess reopened this Dec 6, 2021
mszylkowski
mszylkowski approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@mszylkowski mszylkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL at the comment, and fix the title (as Philip said).

extensions/amp-story-shopping/0.1/amp-story-shopping-tag.js Outdated Show resolved Hide resolved
@jshamble jshamble changed the title ✨ added optProdTagText ✨ Added optional product-tag-text for amp story shopping tag Dec 6, 2021
mszylkowski
mszylkowski requested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@mszylkowski mszylkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until you make the $ only display for prices.

mszylkowski
mszylkowski approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@mszylkowski mszylkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the currency config will be added in a later stage, so lgtm

@jshamble jshamble merged commit f7475a0 into ampproject:main Dec 7, 2021
@processprocess
Copy link
Contributor

Just a note that it's important to post screenshots/demos when working on front end features.
This PR broke styling.

We need to do our best to not introduce regressions in PRs:
Screen Shot 2021-12-08 at 10 11 37 AM

@processprocess processprocess mentioned this pull request Dec 8, 2021
Merged
@jshamble jshamble mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@processprocess processprocess processprocess left review comments

@mszylkowski mszylkowski mszylkowski approved these changes

@coreymasanto coreymasanto Awaiting requested review from coreymasanto

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[amp story shopping] Optional product-tag-text for shopping tag
4 participants
@jshamble @processprocess @mszylkowski @ampprojectbot