Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert "🏗 Parallelize dist steps (#35943)" #36176

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Partially revert "🏗 Parallelize dist steps (#35943)" #36176

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84cd565
Revert "🏗 Parallelize `dist` steps (#35943)"
danielrozenberg Sep 27, 2021
5c4f2a8
Partially allow parallelization for smaller tasks
danielrozenberg Sep 27, 2021
47f7312
Also include `compileAllJs` in the parallelized part
danielrozenberg Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions build-system/tasks/dist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,19 +114,20 @@ async function dist() {
await runPreDistSteps(options);

// These steps use closure compiler. Small ones before large (parallel) ones.
const steps = [];
if (argv.core_runtime_only) {
steps.push(compileCoreRuntime(options));
await compileCoreRuntime(options);
} else {
steps.push(buildExperiments());
steps.push(buildLoginDone('0.1'));
steps.push(buildWebPushPublisherFiles());
steps.push(buildCompiler());
steps.push(compileAllJs(options));
await Promise.all([
buildExperiments(),
buildLoginDone('0.1'),
buildWebPushPublisherFiles(),
buildCompiler(),
]);
await compileAllJs(options);
danielrozenberg marked this conversation as resolved.
Show resolved Hide resolved
}

// This step internally parses the various extension* flags.
steps.push(buildExtensions(options));
await buildExtensions(options);

// This step is to be run only during a full `amp dist`.
if (
Expand All @@ -135,11 +136,9 @@ async function dist() {
!argv.extensions_from &&
!argv.noextensions
) {
steps.push(buildVendorConfigs(options));
await buildVendorConfigs(options);
}

await Promise.all(steps);

// This step is required no matter which binaries are built.
await formatExtractedMessages();

Expand Down