Ensure that aborting layout via unload cancels the layout promise #32099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
force-pushed
the
run3/abort-signal-event
branch
from
74eb38c
to
9a3e80a
Compare
jridgewell
approved these changes
Jan 21, 2021
added 2 commits
January 21, 2021 11:08
jridgewell
requested changes
Jan 21, 2021
jridgewell
approved these changes
Jan 21, 2021
samouri
approved these changes
Jan 21, 2021
|
@dvoytenko: how did you discover this bug? |
|
I was testing very quickly switching from slide to slide in carousel with an iframe. It'd call sometimes |
PetrBlaha
pushed a commit
to PetrBlaha/amphtml
that referenced
this pull request
Jan 28, 2021
…pproject#32099) * Ensure that aborting layout via unload cancels the layout promise * synthetic Event * cleanup * prevent double firing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #31915.