Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource: start storing initialIntersection #31714

Closed
wants to merge 1 commit into from

Conversation

samouri
Copy link
Member

@samouri samouri commented Dec 22, 2020

summary
Ads passes along the initialIntersection to iframes on creation. We have 3 options:

  1. Start providing initialIntersection to layoutCallback
  2. Add the field as deprecated to Resource (this is the PRs current state)
  3. Delay ads rendering (its all happening in promise chains anyway) by however long it takes for a new one-off InOb measurement

Partial for #31540

@samouri
Copy link
Member Author

samouri commented Dec 23, 2020

I was hoping to not make this API and instead switch to async measures using real InOb.
On further inspection though, it would be a gargantuan task to try and make this async since it is used in so many places that expect it to be sync (For example, any place that calls getIframe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant