Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ amp-script: emit warning if zero height and width. #26444

Merged
merged 5 commits into from
Jan 23, 2020
Merged

♻️ amp-script: emit warning if zero height and width. #26444

merged 5 commits into from
Jan 23, 2020

Commits on Jan 23, 2020

  1. Emit warning if attempting to load a 0 height/width amp-script

    @samouri
    samouri committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    b56ee7c View commit details
    Browse the repository at this point in the history

  2. address feedback

    @samouri
    samouri committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    63cfd38 View commit details
    Browse the repository at this point in the history

  3. improve name for layoutCallbackHappened --> layoutCompleted_

    @samouri
    samouri committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    68a9ffb View commit details
    Browse the repository at this point in the history

  4. jridgewell@ nit

    @samouri
    samouri committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    4d6b2d8 View commit details
    Browse the repository at this point in the history

  5. anotha day anotha nit

    @samouri
    samouri committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    b717013 View commit details
    Browse the repository at this point in the history