Refactor EmbeddableService #19771
Merged
Refactor EmbeddableService #19771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dreamofabear
force-pushed
the
fie-refactor-apis
branch
from
ace1df3 to
e5fef1f
Compare
|
/to @alabiaga @dvoytenko |
dvoytenko
approved these changes
Dec 14, 2018
|
@choumx LGTM. A little scary :) |
|
There's a bug with this PR in compiled mode. Closure Compiler will DCE static functions that are not invoked directly: google/closure-compiler#2763 Need to add |
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Dec 19, 2018
* Refactor EmbeddableService. * Half-fix test-extensions. * Important flipped bool, fix test-extensions. * Fix test-service. * Fix test-action. * Make StandardActions more like other FIE services. * Fix test-navigation, test-standard-actions. * Revert timer service change. * Add @nocollapse to installInEmbedWindow() usages.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Refactor EmbeddableService. * Half-fix test-extensions. * Important flipped bool, fix test-extensions. * Fix test-service. * Fix test-action. * Make StandardActions more like other FIE services. * Fix test-navigation, test-standard-actions. * Revert timer service change. * Add @nocollapse to installInEmbedWindow() usages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #16322. Follow-up to #19344.
When installing a service in an FIE, remove the requirement that it must be installed in the parent as well. For example, no need to install amp-bind in the parent if only the child FIE uses it.
EmbeddableServiceinterface to have a static function (so we don't need an preexisting service instance).