🐛 Don't call process.exit() in Karma during normal pass / fail flow #14669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Apr 17, 2018
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Apr 17, 2018
glevitzky
pushed a commit
that referenced
this pull request
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we exit Karma after running tests, it sometimes prematurely exits while its reporters are busy writing to the console. This also breaks Travis log folding, and makes the logs difficult to read. For example, see https://travis-ci.org/ampproject/amphtml/jobs/367291014#L1391-L1397
Unfortunately, this is due to the asynchronous nature of stdout in nodejs. See nodejs/node#6456, nodejs/node#6379, yarnpkg/yarn#5005, etc.
In #14653, we tried to flush stdout before exiting. It turns out that
process.exit()is the wrong way to exit from a Karma process after tests have run. This PR removes calls toprocess.exit()from all normal exit flows, and instead, allows the resolver to do its thing.Follow up to #14653