performance-impl: cant check ampdoc vis hidden while null (#36197)

* performance-impl: cant check ampdoc vis hidden before initted * Add unit test
ampproject · Sep 29, 2021 · 39162ab · 39162ab
1 parent 3e9f5db
commit 39162ab
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/service/performance-impl.js b/src/service/performance-impl.js
@@ -556,9 +556,14 @@ export class Performance {
    * @param {!LayoutShift} entry
    */
   tickLayoutShiftScore_(entry) {
+    if (!this.ampdoc_) {
+      return;
+    }
+
     if (this.isVisibilityHidden_()) {
       return;
     }
+
     const entries = this.layoutShiftEntries_;
     if (entries.length > 0) {
       const first = entries[0];

diff --git a/test/unit/test-performance.js b/test/unit/test-performance.js
@@ -1167,6 +1167,22 @@ describes.realWin('PeformanceObserver metrics', {amp: true}, (env) => {
       return Services.performanceFor(env.win);
     }
 
+    it('should not throw when layout-shift occurs before core services available', () => {
+      // Fake the Performance API.
+      env.win.PerformanceObserver.supportedEntryTypes = ['layout-shift'];
+      const perf = getPerformance();
+
+      // Fake layout-shift that occured before core services registered
+      performanceObserver.triggerCallback({
+        getEntries() {
+          return [
+            {entryType: 'layout-shift', value: 0.3, hadRecentInput: false},
+          ];
+        },
+      });
+      perf.coreServicesAvailable();
+    });
+
     it('when the viewer visibility changes to inactive', () => {
       // Specify an Android Chrome user agent.
       env.sandbox