Add customizer theme support #952
Conversation
|
@DavidCramer FYI: Note the re-organization here for form handling. This will probably impact #936 |
|
Thanks @westonruter . |
westonruter
changed the title
| @@ -178,6 +207,7 @@ public static function register_hooks() { | |||
| */ | |||
| add_action( 'template_redirect', array( __CLASS__, 'start_output_buffering' ), 0 ); | |||
|
|
|||
| // Commenting hooks. | |||
There was a problem hiding this comment.
During the upcoming cleanup, I would suggest to move comments, widgets etc. in their on classes.
includes/class-amp-theme-support.php
Outdated
| add_filter( 'comment_post_redirect', function() { | ||
| // We don't need any data, so just send a success. | ||
| wp_send_json_success(); | ||
| }, PHP_INT_MAX, 2 ); |
There was a problem hiding this comment.
Why passing 2 args here, I believe this is perhaps a left over?
includes/class-amp-theme-support.php
Outdated
| }, PHP_INT_MAX, 2 ); | ||
| self::handle_xhr_headers_output(); | ||
| } elseif ( ! empty( self::$purged_amp_query_vars['_wp_amp_action_xhr_converted'] ) ) { | ||
| add_filter( 'wp_redirect', array( __CLASS__, 'intercept_post_request_redirect' ), PHP_INT_MAX, 2 ); |
There was a problem hiding this comment.
Why passing 2 args here, I believe this is perhaps a left over?
|
|
||
| // Dequeue styles unnecessary unless in customizer preview iframe when editing (such as for edit shortcuts). | ||
| if ( ! self::is_customize_preview_iframe() ) { | ||
| wp_dequeue_style( 'customize-preview' ); |
There was a problem hiding this comment.
What about just doing wp_deregister_style( 'customize-preview' ); so that we don't have to loop through dependencies?
There was a problem hiding this comment.
That could work, but it would also result in something like Query Monitor issuing a warning about a dependency missing.
…dd/customizer-theme-support
Add AMP component scripts when selective refresh results in a new component added.Irrelevant since AMP apparently does this automatically.is_customize_preview(). Scripts need to be enqueued regardless of the user being in theiframesince frontend previewing depends on JS injecting thecustomize_changeset_uuidinto requests.customize-preview.csscan be included.Fixes #901.