Prepare AMP response at shutdown instead of output buffer callback #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThierryA
requested changes
Feb 5, 2018
includes/class-amp-theme-support.php
Outdated
| * @see AMP_Theme_Support::start_output_buffering() | ||
| */ | ||
| public static function finish_output_buffering() { | ||
| $output = ob_get_clean(); |
There was a problem hiding this comment.
I would advise to avoid storing the output in a variable unless necessary, especially in the context of the output buffer. For instance the memory goes from 3018376 to 3006088 on my local install by moving ob_get_clean() to self::prepare_response( ob_get_clean() );.
ThierryA
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to debug things since printing can be done in shutdown function but cannot in output buffer callback.
Furthermore, this prevents a fatal error if
print_r()is attempted in the output buffer callback: