Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full document sanitization in theme support #929

Merged
merged 17 commits into from
Feb 5, 2018
Merged

Add full document sanitization in theme support #929

merged 17 commits into from
Feb 5, 2018

Commits on Feb 4, 2018

  1. Stop excluding children of HEAD

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    0d01dbb View commit details
    Browse the repository at this point in the history

  2. Include extension_spec in exported tag_spec

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    c6e68b7 View commit details
    Browse the repository at this point in the history

  3. Rework output buffering sanitization to apply to entire doc

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    62cbd6c View commit details
    Browse the repository at this point in the history

  4. Add ability to use html document element as sanitization root 

    * Sanitize the elements in the HEAD.
* Deprecate get_body_node in favor of getting html or body element once and storing in var.
* Add support for alternative attribute names in check for mandatory attributes.
* Expand use of NAME_VALUE_DISPATCH for other value matching results.
    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    372412b View commit details
    Browse the repository at this point in the history

  5. Prevent lower-casing regex values from spec

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    8c39957 View commit details
    Browse the repository at this point in the history

  6. Exclude amp4ads rules from spec; omit html_format since unused

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    cd53fce View commit details
    Browse the repository at this point in the history

  7. Add tests for sanitizing the html document element as a whole

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    d8c4054 View commit details
    Browse the repository at this point in the history

  8. Allow enqueued font URLs to be printed normally as stylesheet links

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    f6ccbe9 View commit details
    Browse the repository at this point in the history

  9. Enforce html element to have amp attribute if not present

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    af0da8c View commit details
    Browse the repository at this point in the history

  10. Re-write amphtml-update.py to use PHP for serializing 

    This reduces a lot of complexity and as well as it fixes errors in the PHP-generation
    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    7adb70f View commit details
    Browse the repository at this point in the history

  11. Just-in-time ensure that meta charset, meta viewport, and rel=canonic… 

    …al link are present
    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    d4db6d5 View commit details
    Browse the repository at this point in the history

  12. Just-in-time add meta charset if not initially present

    @westonruter
    westonruter committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    85cc9bd View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Eliminate needless use of dispatch_key and looping over attr spec lis… 

    …ts once failure found
    @westonruter
    westonruter committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    67b6de6 View commit details
    Browse the repository at this point in the history

  2. Add support for value_properties, validating meta viewport content an… 

    …d X-UA-Compatible content
    @westonruter
    westonruter committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    9797778 View commit details
    Browse the repository at this point in the history

  3. Update use of constants in AMP_Rule_Spec 

    * Remove newly-unused dispatch key constant.
* Use integers for flags.
* Use constants instead of string literals.
    @westonruter
    westonruter committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    b8036f7 View commit details
    Browse the repository at this point in the history

  4. Eliminate hard-coding of keyframes max_size

    @westonruter
    westonruter committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    284746a View commit details
    Browse the repository at this point in the history

  5. Ensure styles in head get sanitized like styles output in body

    @westonruter
    westonruter committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    fdc9c4e View commit details
    Browse the repository at this point in the history