Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erroneous additional allowance of script[type=text/javascript] #884

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

westonruter
Copy link
Member

Issue introduced in #828 via 5c1fa20 when attempting to remove duplicated script array key. Since the latter duplicated key with the AMP-valid application/json it previously overrode the erroneous text/javascript entry. When the latter was removed, the former was left which was invalid. So this change ensures that the previous behavior is retained.

Fixes #883.

@ThierryA ThierryA merged commit a5629f9 into 0.6 Jan 22, 2018
@ThierryA ThierryA deleted the fix/script-additional-allowed-tag branch January 22, 2018 20:11
@westonruter westonruter added this to the v0.6 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants