Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create-embed-test-post script and fix support for various embeds #829

Merged
merged 25 commits into from
Dec 14, 2017

Commits on Dec 12, 2017

  1. Configuration menu
    Copy the full SHA
    a6fda64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ef9768 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2017

  1. Issue 806 : Add media and embeds to test page.

    Use Weston's wp-cli script to create a test post.
    Add media items to the post content.
    And add several embeds.
    Several embeds are still not rendering,
    Even on a standard, non-AMP page.
    Ryan Kienstra committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    550ed65 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'add/806-add-script-for-testing-content' of https://gith…

    …ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
    Ryan Kienstra committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    369696b View commit details
    Browse the repository at this point in the history
  3. Issue 806 : Align equals signs vertically.

    Before, the equals sign alignment caused a PHPCS warning.
    Fix this, to enable the Travis build to succeed.
    Ryan Kienstra committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    7c77752 View commit details
    Browse the repository at this point in the history
  4. Issue 804 : Test WordPress post embeds.

    create-embed-test-post.php needs to test all post content.
    As Weston mentioned, embedded posts are part of this.
    Ryan Kienstra committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    128836c View commit details
    Browse the repository at this point in the history
  5. Issue 806 : code improvement

    ThierryA committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    b8ba836 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2017

  1. Fix rendering of SoundCloud embeds and correct parameters for soundcl…

    …oud shortcode
    
    * Hook into oEmbed filters for rewriting SoundCloud embeds as AMP components.
    * Ensure Jetpack is active while unit tests are run.
    * Explicitly install and activate Jetpack during unit tests.
    * Fix error message in create-embed-test-post.php
    * Fix phpcs for Soundcloud code.
    westonruter committed Dec 14, 2017
    1 Configuration menu
    Copy the full SHA
    0b729b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    938be72 View commit details
    Browse the repository at this point in the history
  3. Fix handling of polldaddy oEmbeds in AMP

    * Use noscript response from oEmbed as default content.
    * Include WPCOM_AMP_Polldaddy_Embed by default even when not on WordPress.com; deprecate wpcom/shortcodes.php.
    * Fix DailyMotion and FunnyOrDie test URLs.
    * Clean phpcs for class-amp-polldaddy-embed.php
    westonruter committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    45c538c View commit details
    Browse the repository at this point in the history
  4. Issue 806 : Add instructions for using the wp-cli test page script.

    Add steps to contributing.md to use create-embed-test-post.php.
    Include a step that this should be inside an environment like VVV.
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    52b306b View commit details
    Browse the repository at this point in the history
  5. Merge branch 'add/806-add-script-for-testing-content' of https://gith…

    …ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    13132ed View commit details
    Browse the repository at this point in the history
  6. Issue 804 : Add Amazon, Animoto, and Speakerdeck URLs

    Add these URLs to test oEmbed.
    Use the Amazon testing URLs in:
    https://core.trac.wordpress.org/ticket/38181
    Props @jsepia for these URLs.
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    eaf5157 View commit details
    Browse the repository at this point in the history
  7. Issue 804 : Update the Scribd URL.

    Use the URL from @wonderboymusic in:
    https://core.trac.wordpress.org/ticket/28379.
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    8e34745 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b22e12a View commit details
    Browse the repository at this point in the history
  9. Remove DoubleArrowNotAligned PHPCS suppression

    * Add missing since tag
    * Update filter_embed_oembed_html calls since $url is required
    * Add DEFAULT_BASE_BRANCH=develop
    * Use create_and_get in test
    westonruter committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    f1ee3de View commit details
    Browse the repository at this point in the history
  10. Fix order of sanitizers to ensure whitelist applies at end, after ifr…

    …ame sanitizer has run
    
    Issue introduced in 575ac66
    westonruter committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    a91d7ad View commit details
    Browse the repository at this point in the history
  11. Issue 806 : Update the Photobucket and Scribd URLs.

    Thanks to ohthenoes for the Photobucket link in:
    https://core.trac.wordpress.org/ticket/13754
    And thanks to @wonderboymusic for the Scribd URL from:
    https://core.trac.wordpress.org/ticket/28379.
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    499e580 View commit details
    Browse the repository at this point in the history
  12. Issue 806 : Merge in feature branch, resolve conflicts.

    The only conflict was from array alignment.
    It was a whitespace-only edit.
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    6309f41 View commit details
    Browse the repository at this point in the history
  13. Issue 806 : Remove Vine embed, add Screencast embed.

    Add a Screencast embed, thanks to designsimply's URL in:
    https://core.trac.wordpress.org/ticket/24660
    Because Vine isn't supported anymore, remove its test URL.
    @see wordpress-develop/src/wp-includes/class-oembed.php
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    d2dd032 View commit details
    Browse the repository at this point in the history
  14. Issue 806 : Add tests for Someecards.

    Both the full URL, and the short URL ending with the TLD .ly.
    They both render well in AMP.
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    8732936 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5bce94f View commit details
    Browse the repository at this point in the history
  16. Issue 806 : Correct embeds, including Imgur, Polldaddy, Screencast.

    Change the URLs for most of these.
    And remove the soundcloud shortcode.
    This isn't supported natively.
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    e885b7a View commit details
    Browse the repository at this point in the history
  17. Merge branch 'add/806-add-script-for-testing-content' of https://gith…

    …ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    a485be1 View commit details
    Browse the repository at this point in the history
  18. Issue 806 : Update Photobucket, Tumblr, remove Imgur.

    Use mrdenn1s's image from his Trac ticket:
    https://core.trac.wordpress.org/ticket/28345
    It looks like Imgur oEmbeds no longer work in WordPress.
    @see https://core.trac.wordpress.org/ticket/42247
    Ryan Kienstra committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    ed6088d View commit details
    Browse the repository at this point in the history