-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create-embed-test-post script and fix support for various embeds #829
Commits on Dec 12, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a6fda64 - Browse repository at this point
Copy the full SHA a6fda64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ef9768 - Browse repository at this point
Copy the full SHA 6ef9768View commit details
Commits on Dec 13, 2017
-
Issue 806 : Add media and embeds to test page.
Use Weston's wp-cli script to create a test post. Add media items to the post content. And add several embeds. Several embeds are still not rendering, Even on a standard, non-AMP page.
Ryan Kienstra committedDec 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 550ed65 - Browse repository at this point
Copy the full SHA 550ed65View commit details -
Merge branch 'add/806-add-script-for-testing-content' of https://gith…
…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
Ryan Kienstra committedDec 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 369696b - Browse repository at this point
Copy the full SHA 369696bView commit details -
Issue 806 : Align equals signs vertically.
Before, the equals sign alignment caused a PHPCS warning. Fix this, to enable the Travis build to succeed.
Ryan Kienstra committedDec 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 7c77752 - Browse repository at this point
Copy the full SHA 7c77752View commit details -
Issue 804 : Test WordPress post embeds.
create-embed-test-post.php needs to test all post content. As Weston mentioned, embedded posts are part of this.
Ryan Kienstra committedDec 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 128836c - Browse repository at this point
Copy the full SHA 128836cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8ba836 - Browse repository at this point
Copy the full SHA b8ba836View commit details
Commits on Dec 14, 2017
-
Fix rendering of SoundCloud embeds and correct parameters for soundcl…
…oud shortcode * Hook into oEmbed filters for rewriting SoundCloud embeds as AMP components. * Ensure Jetpack is active while unit tests are run. * Explicitly install and activate Jetpack during unit tests. * Fix error message in create-embed-test-post.php * Fix phpcs for Soundcloud code.
1Configuration menu - View commit details
-
Copy full SHA for 0b729b1 - Browse repository at this point
Copy the full SHA 0b729b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 938be72 - Browse repository at this point
Copy the full SHA 938be72View commit details -
Fix handling of polldaddy oEmbeds in AMP
* Use noscript response from oEmbed as default content. * Include WPCOM_AMP_Polldaddy_Embed by default even when not on WordPress.com; deprecate wpcom/shortcodes.php. * Fix DailyMotion and FunnyOrDie test URLs. * Clean phpcs for class-amp-polldaddy-embed.php
Configuration menu - View commit details
-
Copy full SHA for 45c538c - Browse repository at this point
Copy the full SHA 45c538cView commit details -
Issue 806 : Add instructions for using the wp-cli test page script.
Add steps to contributing.md to use create-embed-test-post.php. Include a step that this should be inside an environment like VVV.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 52b306b - Browse repository at this point
Copy the full SHA 52b306bView commit details -
Merge branch 'add/806-add-script-for-testing-content' of https://gith…
…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 13132ed - Browse repository at this point
Copy the full SHA 13132edView commit details -
Issue 804 : Add Amazon, Animoto, and Speakerdeck URLs
Add these URLs to test oEmbed. Use the Amazon testing URLs in: https://core.trac.wordpress.org/ticket/38181 Props @jsepia for these URLs.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for eaf5157 - Browse repository at this point
Copy the full SHA eaf5157View commit details -
Issue 804 : Update the Scribd URL.
Use the URL from @wonderboymusic in: https://core.trac.wordpress.org/ticket/28379.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 8e34745 - Browse repository at this point
Copy the full SHA 8e34745View commit details -
Configuration menu - View commit details
-
Copy full SHA for b22e12a - Browse repository at this point
Copy the full SHA b22e12aView commit details -
Remove DoubleArrowNotAligned PHPCS suppression
* Add missing since tag * Update filter_embed_oembed_html calls since $url is required * Add DEFAULT_BASE_BRANCH=develop * Use create_and_get in test
Configuration menu - View commit details
-
Copy full SHA for f1ee3de - Browse repository at this point
Copy the full SHA f1ee3deView commit details -
Fix order of sanitizers to ensure whitelist applies at end, after ifr…
…ame sanitizer has run Issue introduced in 575ac66
Configuration menu - View commit details
-
Copy full SHA for a91d7ad - Browse repository at this point
Copy the full SHA a91d7adView commit details -
Issue 806 : Update the Photobucket and Scribd URLs.
Thanks to ohthenoes for the Photobucket link in: https://core.trac.wordpress.org/ticket/13754 And thanks to @wonderboymusic for the Scribd URL from: https://core.trac.wordpress.org/ticket/28379.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 499e580 - Browse repository at this point
Copy the full SHA 499e580View commit details -
Issue 806 : Merge in feature branch, resolve conflicts.
The only conflict was from array alignment. It was a whitespace-only edit.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 6309f41 - Browse repository at this point
Copy the full SHA 6309f41View commit details -
Issue 806 : Remove Vine embed, add Screencast embed.
Add a Screencast embed, thanks to designsimply's URL in: https://core.trac.wordpress.org/ticket/24660 Because Vine isn't supported anymore, remove its test URL. @see wordpress-develop/src/wp-includes/class-oembed.php
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for d2dd032 - Browse repository at this point
Copy the full SHA d2dd032View commit details -
Issue 806 : Add tests for Someecards.
Both the full URL, and the short URL ending with the TLD .ly. They both render well in AMP.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 8732936 - Browse repository at this point
Copy the full SHA 8732936View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bce94f - Browse repository at this point
Copy the full SHA 5bce94fView commit details -
Issue 806 : Correct embeds, including Imgur, Polldaddy, Screencast.
Change the URLs for most of these. And remove the soundcloud shortcode. This isn't supported natively.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for e885b7a - Browse repository at this point
Copy the full SHA e885b7aView commit details -
Merge branch 'add/806-add-script-for-testing-content' of https://gith…
…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for a485be1 - Browse repository at this point
Copy the full SHA a485be1View commit details -
Issue 806 : Update Photobucket, Tumblr, remove Imgur.
Use mrdenn1s's image from his Trac ticket: https://core.trac.wordpress.org/ticket/28345 It looks like Imgur oEmbeds no longer work in WordPress. @see https://core.trac.wordpress.org/ticket/42247
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for ed6088d - Browse repository at this point
Copy the full SHA ed6088dView commit details