Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update allowed tags #805

Closed
wants to merge 2 commits into from
Closed

[WIP] Update allowed tags #805

wants to merge 2 commits into from

Conversation

westonruter
Copy link
Member

See #804 for details. This doesn't yet result in successful generation of the allowed tags. Currently fails with:

python3 amp_wp_build.py
[[amp_wp_build.py SetupOutDir]] - entering ...
[[amp_wp_build.py SetupOutDir]] - ... done
[[amp_wp_build.py GenValidatorProtoascii]] - entering ...
[[amp_wp_build.py GenValidatorProtoascii]] - ... done
[[amp_wp_build.py GenValidatorPb2Py]] - entering ...
[[amp_wp_build.py GenValidatorPb2Py]] - ... done
[[amp_wp_build.py GenValidatorProtoascii]] - entering ...
[[amp_wp_build.py GenValidatorProtoascii]] - ... done
[[amp_wp_build.py GeneratePHP]] - entering ...
[[amp_wp_build.py ParseRules]] - entering ...
Traceback (most recent call last):
  File "amp_wp_build.py", line 604, in <module>
    Main()
  File "amp_wp_build.py", line 601, in Main
    GeneratePHP(out_dir)
  File "amp_wp_build.py", line 118, in GeneratePHP
    allowed_tags, attr_lists, versions = ParseRules(out_dir)
  File "amp_wp_build.py", line 359, in ParseRules
    text_format.Merge(open(specfile).read(), rules)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 525, in Merge
    descriptor_pool=descriptor_pool)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 579, in MergeLines
    return parser.MergeLines(lines, message)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 612, in MergeLines
    self._ParseOrMerge(lines, message)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 627, in _ParseOrMerge
    self._MergeField(tokenizer, message)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 727, in _MergeField
    merger(tokenizer, message, field)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 815, in _MergeMessageField
    self._MergeField(tokenizer, sub_message)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 727, in _MergeField
    merger(tokenizer, message, field)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 866, in _MergeScalarField
    value = tokenizer.ConsumeString()
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 1229, in ConsumeString
    the_bytes = self.ConsumeByteString()
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 1244, in ConsumeByteString
    the_list = [self._ConsumeSingleByteString()]
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_format.py", line 1269, in _ConsumeSingleByteString
    result = text_encoding.CUnescape(text[1:-1])
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_encoding.py", line 103, in CUnescape
    result = ''.join(_cescape_highbit_to_str[ord(c)] for c in result)
  File "/usr/local/lib/python3.6/site-packages/google/protobuf/text_encoding.py", line 103, in <genexpr>
    result = ''.join(_cescape_highbit_to_str[ord(c)] for c in result)
IndexError: list index out of range

Fixes #804 (and potentially many other issues)

@westonruter westonruter added this to the v0.6 milestone Nov 13, 2017
@westonruter westonruter deleted the update/allowed-tags branch July 5, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant