Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Google Analytics analytics vendor #7580

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Update Google Analytics analytics vendor #7580

merged 7 commits into from
Jul 10, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jul 10, 2023 •
edited
Loading

Summary

  • Append (Legacy) to Google Analytics vendor.
  • Add warning notice if using Google Analytics.
  • Update analytics vendors.

Fixes #7567

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

Plugin builds for 1451872 are ready 🛎️!

@thelovekesh thelovekesh requested a review from westonruter July 10, 2023 18:37
This was referenced Jul 10, 2023
Merged
Merged
westonruter
westonruter approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@westonruter westonruter merged commit 856745e into develop Jul 10, 2023
@westonruter westonruter deleted the update/googleanalytics-label branch July 10, 2023 22:07
@westonruter westonruter added this to the v2.4.2 milestone Jul 10, 2023
@thelovekesh thelovekesh added Bug Something isn't working Enhancement New feature or improvement of an existing one P2 Low priority Reader Mode WS:Core Work stream for Plugin core and removed Bug Something isn't working Enhancement New feature or improvement of an existing one P2 Low priority Reader Mode WS:Core Work stream for Plugin core labels Jul 13, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4.2
Development

Successfully merging this pull request may close these issues.

Deprecate googleanalytics (UA) vendor type in favor of gtag (GA4)
2 participants
@thelovekesh @westonruter