Fix failing PHPUnit tests

[thelovekesh]

Summary

• Add a step to keep the PHPUnit version to 9.3 on PHP 7.3, 7.4, and 8.0 in the workflow.
• Fix embeds URL for Tumblr.

Checklist

• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[github-actions]

Plugin builds for 3be7426 are ready 🛎️!

• Download development build
• Download production build

[thelovekesh]

@westonruter While updating the phpunit version in Build, test & measure workflow, the PHPUnit version gets updated to 9.5.28 which is PHP 8.1 compatible, and throws an error like Error: Call to undefined function enum_exists().

enum_exists() gets introduced in PHP 8.1.

To avoid this error we will need to setup PHPUnit v9.3 here instead of letting it decide by the composer with yoast/phpunit-polyfills.

amp-wp/.github/workflows/build-test-measure.yml

Line 507 in d34ba40

composer update --ignore-platform-reqs --no-interaction --no-scripts yoast/phpunit-polyfills --with-dependencies

[westonruter]

the PHPUnit version gets updated to 9.5.28 which is PHP 8.1 compatible

In other words, it requires PHP 8.1 as a minimum?

SGTM regardless.

[codecov]

Codecov Report

Merging #7419 (7507dc7) into develop (7f9b28b) will increase coverage by 12.07%.
The diff coverage is n/a.

❗ Current head 7507dc7 differs from pull request most recent head 3be7426. Consider uploading reports for the commit 3be7426 to get more accurate results

@@              Coverage Diff               @@
##             develop    #7419       +/-   ##
==============================================
+ Coverage      64.76%   76.83%   +12.07%     
- Complexity         0     6864     +6864     
==============================================
  Files             67      281      +214     
  Lines           1189    27232    +26043     
==============================================
+ Hits             770    20925    +20155     
- Misses           419     6307     +5888     

Flag	Coverage Δ
javascript	64.76% <ø> (ø)
php	77.39% <ø> (?)
unit	77.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...udes/sanitizers/class-amp-pwa-script-sanitizer.php	100.00% <0.00%> (ø)
.../Transformer/AmpSchemaOrgMetadataConfiguration.php	0.00% <0.00%> (ø)
src/Cli/TransformerCommand.php	0.00% <0.00%> (ø)
src/Optimizer/AmpWPConfiguration.php	100.00% <0.00%> (ø)
src/Exception/InvalidEventProperties.php	96.29% <0.00%> (ø)
src/BackgroundTask/RecurringBackgroundTask.php	100.00% <0.00%> (ø)
includes/sanitizers/class-amp-form-sanitizer.php	18.42% <0.00%> (ø)
includes/embeds/class-amp-meetup-embed-handler.php	22.22% <0.00%> (ø)
...des/embeds/class-amp-crowdsignal-embed-handler.php	75.00% <0.00%> (ø)
includes/sanitizers/class-amp-iframe-sanitizer.php	96.40% <0.00%> (ø)
... and 204 more

[thelovekesh]

@westonruter This PR need to be merged before proceeding to any other PR that runs the PHPUnit tests workflow.

[westonruter]

What about when PHP 8.3 comes out?

[westonruter]

I guess this will depend on us updating the matrix, so nevermind.

[westonruter]

Should this rather be:

Suggested change

	composer require --dev --ignore-platform-reqs phpunit/phpunit:"=9.3" --with-dependencies
	composer require --dev --ignore-platform-reqs phpunit/phpunit:"=9.3.*" --with-dependencies

As this would account for bug fixes for that branch?

[thelovekesh]

Nice catch. It should rather be composer require --dev --ignore-platform-reqs phpunit/phpunit:"9.3.*" --with-dependencies as "=9.3.*" is an invalid version string.