Eliminate "AMP Settings" panel from Gallery block and move them to AMP advanced settings

[thelovekesh]

Summary

This PR aims to move AMP Settings panel from the gallery block to advanced settings.

Fixes #4989

Checklist

• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[github-actions]

Plugin builds for 7f3c065 are ready 🛎️!

• Download development build
• Download production build

[codecov]

Codecov Report

Merging #7171 (67983f4) into develop (0bf2bbb) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head 67983f4 differs from pull request most recent head 22c4181. Consider uploading reports for the commit 22c4181 to get more accurate results

@@              Coverage Diff              @@
##             develop    #7171      +/-   ##
=============================================
- Coverage      77.45%   77.43%   -0.03%     
+ Complexity      7123     7116       -7     
=============================================
  Files            275      274       -1     
  Lines          22086    22053      -33     
=============================================
- Hits           17106    17076      -30     
+ Misses          4980     4977       -3     

Flag	Coverage Δ
javascript	64.86% <ø> (-0.02%)	⬇️
php	78.12% <50.00%> (-0.03%)	⬇️
unit	78.12% <50.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
assets/src/block-editor/helpers/index.js	23.61% <ø> (-4.79%)	⬇️
src/OptionsRESTController.php	59.78% <ø> (ø)
includes/embeds/class-amp-core-block-handler.php	93.20% <16.66%> (-2.30%)	⬇️
includes/options/class-amp-options-manager.php	90.95% <100.00%> (+0.18%)	⬆️
includes/amp-helper-functions.php	84.89% <0.00%> (-0.03%)	⬇️
...udes/sanitizers/class-amp-pwa-script-sanitizer.php	100.00% <0.00%> (ø)
...zers/class-amp-native-img-attributes-sanitizer.php
includes/sanitizers/class-amp-img-sanitizer.php	97.33% <0.00%> (+2.09%)	⬆️

[thelovekesh]

Failing tests have been fixed in - #7158

[westonruter]

As I understand, this PR moves the gallery/lightbox settings from an individual block to be a global settings. I don't think will work out because a user may want a carousel for one gallery block but not have it for another block. I realize #4989 is not particularly clear as it was more of a issue for more discovery, but I recall the idea for global settings was whether to control whether the block-specific settings would be exposed. For example, let's say you are using Jetpack and all galleries already have lightboxes. In that case, the checkbox for AMP lightbox is redundant and shouldn't be presented to all users for every single block.

Instead of removing the AMP-specific toggles, can the AMP toggles be moved to the Advanced panel so as to eliminate the AMP Settings panel?

[thelovekesh]

For example, let's say you are using Jetpack and all galleries already have lightboxes. In that case, the checkbox for AMP lightbox is redundant and shouldn't be presented to all users for every single block.

Agree 💯

I will move them to the Advanced Settings 👍🏼

[thelovekesh]

@westonruter Can you give it a round of review?

[westonruter]

LGTM!