Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing async module after grunt bump to 1.5.3 #7153

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jun 15, 2022

Summary

  • This PR aims to fix Cannot find module 'async' error when running grunt tasks.
  • Update caniuse-lite package

Before:
image

After running command npm i grunt -f:
image

Fixes #7148

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Jun 15, 2022
@thelovekesh thelovekesh requested a review from westonruter June 15, 2022 09:19
@thelovekesh thelovekesh force-pushed the fix/async-module-missing branch from 91a6762 to f309bad Compare June 15, 2022 09:20
@thelovekesh thelovekesh marked this pull request as ready for review June 15, 2022 17:59
@github-actions
Copy link
Contributor

Plugin builds for 4d49582 are ready 🛎️!

@westonruter westonruter added this to the v2.3.1 milestone Jun 15, 2022
@westonruter
Copy link
Member

I also ran npx browserslist@latest --update-db and here is the diff:

Target browser changes:
- and_chr 95
+ and_chr 102
- android 95
+ android 101
- chrome 95
- chrome 94
- chrome 93
+ chrome 102
+ chrome 101
+ chrome 100
- edge 95
- edge 94
+ edge 102
+ edge 101
- firefox 94
- firefox 93
+ firefox 101
+ firefox 100
- ios_saf 15
- ios_saf 14.0-14.4
+ ios_saf 15.5
+ ios_saf 15.4
+ ios_saf 15.2-15.3
- op_mini all
- opera 81
- opera 80
+ opera 86
+ opera 85
- safari 15
- safari 14.1
+ safari 15.5
+ safari 15.4
- samsung 15.0

@westonruter
Copy link
Member

With the changes here, I no longer get async errors when I run npx grunt shell:verify_matching_versions.

@westonruter
Copy link
Member

The changes from sha1 to sha512 seem unintended, right? When I npm install it reverts back to sha1. If I blow away node_modules and then re-install, then the sha512 sticks. The only difference then is:

diff --git a/package-lock.json b/package-lock.json
index da33e634b..5a730ae71 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -6813,6 +6813,12 @@
             "semver": "^7.3.5"
           }
         },
+        "prettier": {
+          "version": "npm:[email protected]",
+          "resolved": "https://registry.npmjs.org/wp-prettier/-/wp-prettier-2.2.1-beta-1.tgz",
+          "integrity": "sha512-+JHkqs9LC/JPp51yy1hzs3lQ7qeuWCwOcSzpQNeeY/G7oSpnF61vxt7hRh87zNRTr6ob2ndy0W8rVzhgrcA+Gw==",
+          "dev": true
+        },
         "schema-utils": {
           "version": "4.0.0",
           "resolved": "https://registry.npmjs.org/schema-utils/-/schema-utils-4.0.0.tgz",
@@ -19647,12 +19653,6 @@
       "integrity": "sha512-vkcDPrRZo1QZLbn5RLGPpg/WmIQ65qoWWhcGKf/b5eplkkarX0m9z8ppCat4mlOqUsWpyNuYgO3VRyrYHSzX5g==",
       "dev": true
     },
-    "prettier": {
-      "version": "npm:[email protected]",
-      "resolved": "https://registry.npmjs.org/wp-prettier/-/wp-prettier-2.2.1-beta-1.tgz",
-      "integrity": "sha512-+JHkqs9LC/JPp51yy1hzs3lQ7qeuWCwOcSzpQNeeY/G7oSpnF61vxt7hRh87zNRTr6ob2ndy0W8rVzhgrcA+Gw==",
-      "dev": true
-    },
     "prettier-linter-helpers": {
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/prettier-linter-helpers/-/prettier-linter-helpers-1.0.0.tgz",

@westonruter westonruter merged commit 12e0506 into develop Jun 15, 2022
@westonruter westonruter deleted the fix/async-module-missing branch June 15, 2022 21:08
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browserslist: caniuse-lite is outdated
2 participants