Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show 'Desktop Expanded menu' of twenty-twenty in AMP mode #7094

Merged
merged 2 commits into from
May 26, 2022
Merged

Show 'Desktop Expanded menu' of twenty-twenty in AMP mode #7094

merged 2 commits into from
May 26, 2022

Conversation

dhaval-parekh
Copy link
Collaborator

@dhaval-parekh dhaval-parekh commented May 9, 2022 •
edited
Loading

Summary

Fixes #7056

Before (AMP Mode)

image

After (AMP Mode)

desktop-expanded-menu.mov

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh requested a review from milindmore22 May 9, 2022 14:15
@dhaval-parekh dhaval-parekh marked this pull request as ready for review May 9, 2022 14:15
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022 •
edited
Loading

Plugin builds for 9915321 are ready 🛎️!

@dhaval-parekh dhaval-parekh self-assigned this May 11, 2022
milindmore22
milindmore22 approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@milindmore22 milindmore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@westonruter westonruter added this to the v2.3 milestone May 26, 2022
@westonruter westonruter merged commit e491a91 into develop May 26, 2022
@westonruter westonruter deleted the bug/7056-twenty-twenty-desktop-menu branch May 26, 2022 17:24
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milindmore22 milindmore22 milindmore22 approved these changes

Assignees

@dhaval-parekh dhaval-parekh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

Desktop Expanded menu not Working on the Twenty Twenty Theme
3 participants
@dhaval-parekh @milindmore22 @westonruter