Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix site scanning UI for Safari 14 #7015

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Fix site scanning UI for Safari 14 #7015

merged 3 commits into from
Mar 30, 2022

Conversation

dhaval-parekh
Copy link
Collaborator

@dhaval-parekh dhaval-parekh commented Mar 30, 2022 •
edited
Loading

Summary

Fixes #7013

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh changed the title Fix site scanning UI for Safari 14 WIP Fix site scanning UI for Safari 14 Mar 30, 2022
@dhaval-parekh dhaval-parekh marked this pull request as ready for review March 30, 2022 12:16
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022 •
edited
Loading

Plugin builds for 26a8614 are ready 🛎️!

@dhaval-parekh dhaval-parekh changed the title WIP Fix site scanning UI for Safari 14 Fix site scanning UI for Safari 14 Mar 30, 2022
westonruter
westonruter approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chrome the changes have not negatively impacted the appearance:

State Before After
Closed image image
Open image image

@westonruter westonruter merged commit 01cf0e4 into develop Mar 30, 2022
@westonruter westonruter deleted the bug/7013-safari-ui-glitch branch March 30, 2022 22:09
westonruter added a commit that referenced this pull request Mar 30, 2022
@westonruter @dhaval-parekh
Fix site scanning UI for Safari 14 (#7015)
cc4a65f 
Co-authored-by: Dhaval Parekh <[email protected]>
@westonruter westonruter added this to the v2.2.2 milestone Mar 30, 2022
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@milindmore22 milindmore22 Awaiting requested review from milindmore22

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.

UI glitch in Site scanning in safari browser (version 14.0.3)
2 participants
@dhaval-parekh @westonruter