Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code that strip whitespace around equal signs from meta #6979

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Remove code that strip whitespace around equal signs from meta #6979

merged 1 commit into from
Mar 15, 2022

Conversation

dhaval-parekh
Copy link
Collaborator

@dhaval-parekh dhaval-parekh commented Mar 15, 2022 •
edited
Loading

Summary

Fixes #4742

Remove the code from meta sanitizer that removes white space surrounding the equals signs from meta viewport tag.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh self-assigned this Mar 15, 2022
@dhaval-parekh dhaval-parekh marked this pull request as ready for review March 15, 2022 13:42
@github-actions
Copy link
Contributor

Plugin builds for d4b55c3 are ready 🛎️!

@westonruter westonruter added this to the v2.2.2 milestone Mar 15, 2022
@westonruter westonruter merged commit 1e1fc8e into develop Mar 15, 2022
@westonruter westonruter deleted the bug/4742-remove-extraneous-whitespace-in-meta branch March 15, 2022 23:34
westonruter pushed a commit that referenced this pull request Mar 15, 2022
@dhaval-parekh @westonruter
Remove code that strip whitespace around equal signs from meta (#6979)
8b7ed71
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@milindmore22 milindmore22 Awaiting requested review from milindmore22

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.

Meta viewport properties no longer need extraneous whitespace removed
2 participants
@dhaval-parekh @westonruter