Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checks for image dimensions extraction #6973

Merged
merged 6 commits into from
Mar 14, 2022

Conversation

dhaval-parekh
Copy link
Collaborator

Summary

Fixes #6968

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh self-assigned this Mar 14, 2022
@dhaval-parekh dhaval-parekh marked this pull request as ready for review March 14, 2022 11:36
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2022

Plugin builds for 7cbc8c6 are ready 🛎️!

…image-dimensions-extraction

* 'develop' of github.com:ampproject/amp-wp:
  Approve PR after enabling auto-merge
  Run dependabot auto-merge for minor updates as well as patch updates
  Only run dependabot auto-merge after build, test, and measure has completed
  Bump eslint-plugin-jsdoc from 37.9.7 to 38.0.1
  Bump eslint from 8.10.0 to 8.11.0
  Add amp-anim to dynamic_element_selectors alongside amp-img
  Use native img by default
@westonruter westonruter merged commit 1916a91 into develop Mar 14, 2022
@westonruter westonruter deleted the bug/6968-image-dimensions-extraction branch March 14, 2022 23:07
@westonruter westonruter added this to the v2.2.2 milestone Mar 14, 2022
westonruter added a commit that referenced this pull request Mar 14, 2022
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve checks for image dimensions extraction to avoid warnings
2 participants