Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Twenty Twenty search modal on mobile breakpoint #6967

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

delawski
Copy link
Collaborator

@delawski delawski commented Mar 9, 2022

Summary

Fixes #5404

Re-opening because there's a failure for the Twenty Twenty test:

image

As per #5404 (comment), the E2E tests that were recently added in #6933 are failing for Twenty Twenty theme.

This PR fixes the failing test. Instead of examining a desktop search modal, we're now testing a mobile search modal.

Aside: if it's feasible to add a test for Twenty Twenty-Two as well, that would be great.

Also, the request for adding E2E tests for Twenty Twenty-Two theme navigation block in the header has been addressed here (0d59631).

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@delawski delawski added Bug Something isn't working Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs labels Mar 9, 2022
@delawski delawski added this to the v2.2.2 milestone Mar 9, 2022
@delawski delawski self-assigned this Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Plugin builds for beba916 are ready 🛎️!

@delawski delawski force-pushed the fix/5404-e2e-tests-for-core-themes branch from eb0769b to beba916 Compare March 9, 2022 12:50
@delawski delawski requested a review from westonruter March 9, 2022 13:37
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@westonruter westonruter merged commit a93ddfe into develop Mar 9, 2022
@westonruter westonruter deleted the fix/5404-e2e-tests-for-core-themes branch March 9, 2022 16:46
westonruter added a commit that referenced this pull request Mar 9, 2022
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E tests for the nav menu toggle
2 participants