Replace img with amp-pixel when dealing with Facebook tracking pixel
#6965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for e40d370 are ready 🛎️!
|
westonruter
reviewed
Mar 8, 2022
westonruter
reviewed
Mar 8, 2022
westonruter
reviewed
Mar 8, 2022
westonruter
reviewed
Mar 8, 2022
westonruter
reviewed
Mar 8, 2022
westonruter
reviewed
Mar 8, 2022
| if ( self::is_tracking_pixel_url( $node->getAttribute( Attribute::SRC ) ) ) { | ||
| $amp_pixel_node = AMP_DOM_Utils::create_node( | ||
| $this->dom, | ||
| 'amp-pixel', |
There was a problem hiding this comment.
You could add use AmpProject\Extension; to the top and then here do:
Suggested change
| 'amp-pixel', | |
| Extension::PIXEL, |
There was a problem hiding this comment.
Good idea. Plus, we already have use AmpProject\Extension; at the top. This has been addressed in 0d66f37.
In practice a Facebook pixel should really never be styled by authors. It's supposed to be invisible after all. Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
…059-img-to-amp-pixel * 'develop' of github.com:ampproject/amp-wp: (63 commits) Improve nav menu E2E tests by creating test menu before each test suite Bail out if there is no menu location or it is already selected Add E2E tests for Twenty Twenty-Two header nav menu block Test Twenty Twenty search modal on mobile breakpoint Bump dependabot/fetch-metadata from 1.1.1 to 1.3.0 Improve strings to account for one or more issues Fix type check by passing explicit string as href prop Include SCSS files in the lint-staged config for stylelint Fix stylelint issue Rename 'allowed' to 'associated' Use named functions Add label for why the validation data is being shown Remove wrapping of site-scan-results__source-detail Bump lint-staged from 12.3.4 to 12.3.5 Update perimssions for gutenberg-packages-update workflow Add approve step for auto-merge workflow Add notice step Move conditional from matrix job to its steps Only run PHP feature tests when php files have changed Only run phpunit tests if a PHP file has changed ...
westonruter
approved these changes
Mar 9, 2022
westonruter
added a commit
that referenced
this pull request
Mar 9, 2022
…xel (#6965) Co-authored-by: Piotr Delawski <[email protected]>
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6059
This PR changes the way the
AMP_Img_Sanitizerworks.Whenever a Facebook tracking pixel is encountered, e.g.:
it is is replaced with a more suitable
amp-pixelinstead of genericamp-img.Checklist