Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check_for_page_caching() to account for wp_remote_retrieve_header() returning arrays #6938

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix check_for_page_caching() to account for wp_remote_retrieve_header() returning arrays #6938

merged 1 commit into from
Mar 4, 2022

Conversation

westonruter
Copy link
Member

Fixes #6937.

@westonruter westonruter added this to the v2.2.2 milestone Feb 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2022 •
edited
Loading

Plugin builds for 37d9c19 are ready 🛎️!

@westonruter westonruter force-pushed the fix/page-caching-test-header-arrays branch from 8058ae4 to 37d9c19 Compare March 3, 2022 16:48
dhaval-parekh
dhaval-parekh approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@dhaval-parekh dhaval-parekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@westonruter westonruter merged commit b1430f9 into develop Mar 4, 2022
@westonruter westonruter deleted the fix/page-caching-test-header-arrays branch March 4, 2022 17:05
westonruter added a commit that referenced this pull request Mar 4, 2022
@westonruter
Fix check_for_page_caching() to account for `wp_remote_retrieve_hea…
c7dda15 
…der()` returning arrays (#6938)
@westonruter westonruter mentioned this pull request Mar 29, 2022
Closed
manuelRod added a commit to manuelRod/performance that referenced this pull request Mar 30, 2022
@manuelRod
Fixing array header scenario per AMP approach ampproject/amp-wp#6938
ce59323
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaval-parekh dhaval-parekh dhaval-parekh approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Site Health
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.

Site Health test for page caching does not account for wp_remote_retrieve_header() returning arrays
2 participants
@westonruter @dhaval-parekh