Fix AMP Carousel caption color and position #6907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 636d412 are ready 🛎️!
|
westonruter
approved these changes
Feb 11, 2022
westonruter
added a commit
that referenced
this pull request
Feb 11, 2022
Co-authored-by: Piotr Delawski <[email protected]>
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6734
Captions of images that are part of an AMP Carousel are not getting a correct color and so are hard to read. It turned out that the issue affects not only AMP Carousel but also the core Gallery block (see WordPress/gutenberg#37032).
The solution proposed and used in Gutenberg (WordPress/gutenberg#37033) doesn't work for AMP Carousel since the CSS selectors are different for AMP.
This PR fixes this issue for AMP Carousel.
Check out the before and after on WordPress 5.9 and Twenty Twenty-Two:
While working on this issue and testing it out on Twenty Twenty-One I noticed that the caption does not stick to the bottom edge of the image, leaving an oddly-looking space. I went ahead and fixed this issue as well (bfd96b3).
WordPress 5.6 and Twenty Twenty-One, Gutenberg inactive:
Checklist