Account for validation-wrapped callbacks in plugin suppression #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
fix/plugin-suppression-at-wp-action
branch
from
894dfc4 to
e0ea024
Compare
westonruter
force-pushed
the
fix/plugin-suppression-at-wp-action
branch
from
2978a00 to
0d1b811
Compare
|
Plugin builds for 7be8965 are ready 🛎️!
|
dhaval-parekh
approved these changes
Jan 26, 2022
|
QA Passed. After installing and suppressing the "Auto Add Script to Footer" plugin, No validation errors occur when validating the page. |
westonruter
added a commit
that referenced
this pull request
Jan 26, 2022
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6809
Given the example plugin in #6809, with it being suppressed in Plugin Suppression, the changes in this PR ensure that the plugin's hooks are suppressed even during a validation request (in which they are wrapped to locate sources), just as they are suppressed when making a regular frontend request:
Checklist