Update AMP toolbox to v0.9.3 #6792

schlessera · 2021-12-14T21:45:16Z

Summary

This PR updates the AMP toolbox dependency to v0.9.3.

This should fix a bug with regular expressions breaking down on large SVGs. See ampproject/amp-toolbox-php#441

My code is tested and passes existing tests.
My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

github-actions · 2021-12-14T21:51:12Z

Plugin builds for 7d17178 are ready 🛎️!

delawski · 2021-12-15T11:30:44Z

QA Passed

✅ A large SVG is correctly rendered on an AMP page which means that amp-toolbox version is 0.9.3:

Update AMP toolbox to v0.9.3

7d17178

schlessera requested a review from westonruter December 14, 2021 21:45

schlessera added the Optimizer label Dec 14, 2021

schlessera added this to the v2.2 milestone Dec 14, 2021

swissspidy mentioned this pull request Dec 14, 2021

SelfClosingSVGElements issues with large SVGs ampproject/amp-toolbox-php#441

Closed

westonruter approved these changes Dec 14, 2021

View reviewed changes

westonruter merged commit fda381f into develop Dec 14, 2021

westonruter deleted the fix/update-amp-toolbox-0.9.3 branch December 14, 2021 23:48

westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021