Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure site is not scanned multiple times in Onboarding Wizard #6791

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Ensure site is not scanned multiple times in Onboarding Wizard #6791

merged 2 commits into from
Dec 15, 2021

Conversation

delawski
Copy link
Collaborator

Summary

Fixes #6741

This PR hardens the Site Scan checks in the Onboarding Wizard in order to prevent multiple scans happening when going back to the Site Scan step.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@delawski delawski added Bug Something isn't working Site Scanning labels Dec 14, 2021
@delawski delawski added this to the v2.2 milestone Dec 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021 •
edited
Loading

Plugin builds for 8d49e62 are ready 🛎️!

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
@dhaval-parekh
Copy link
Collaborator

QA Passed

✅ Site scanning is no longer performing more than once on the "Onboarding Wizard"

milindmore22
milindmore22 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@milindmore22 milindmore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed

The site is not scanned multiple times.

@delawski delawski mentioned this pull request Dec 15, 2021
Closed
@westonruter westonruter merged commit 6cf0154 into develop Dec 15, 2021
@westonruter westonruter deleted the fix/scan-once-in-wizard branch December 15, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milindmore22 milindmore22 milindmore22 approved these changes

@dhaval-parekh dhaval-parekh dhaval-parekh approved these changes

@westonruter westonruter Awaiting requested review from westonruter

Assignees
No one assigned
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Site Scanning
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

Site scanning performed multiple times on Onboarding Wizard
4 participants
@delawski @dhaval-parekh @milindmore22 @westonruter