Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete (and unused) SavePostValidationEvent #6771

Closed
wants to merge 1 commit into from

Conversation

westonruter
Copy link
Member

Summary

Now that we have Site Scanning in place along with the URLValidationCron, there is very little need for a scheduled task that checks every single URL that has been modified. In fact, the SavePostValidationEvent service (introduced in #5515) has never been enabled since it has been hidden behind a feature flag/filter. Therefore, we should go ahead and just remove it entirely.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added Tech Debt Deprecations, inefficiencies, code health Site Scanning labels Dec 7, 2021
@westonruter westonruter added this to the v2.3 milestone Dec 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

Plugin builds for 9dd7ca3 are ready 🛎️!

@westonruter westonruter modified the milestones: v2.3, v2.2 Dec 9, 2021
@westonruter westonruter changed the title Remove obsolete SavePostValidationEvent Remove obsolete (and unused) SavePostValidationEvent Dec 9, 2021
westonruter added a commit that referenced this pull request Dec 9, 2021
@westonruter
Copy link
Member Author

I've cherry-picked this onto #6773.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Site Scanning Tech Debt Deprecations, inefficiencies, code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant