Use AMP_Validated_URL_Post_Type::get_url_from_post() instead of post_title property
#6764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 969a3ed are ready 🛎️!
|
dhaval-parekh
changed the title
2 tasks
bartoszgadomski
approved these changes
Dec 7, 2021
…support-request * 'develop' of github.com:ampproject/amp-wp: (22 commits) Update Gutenberg package dependencies Run phpunit with verbose Skip SupportLink and SupportScreen tests when Site Health is not present Ensure support links are only added when user has access to support screen Add view_site_health_checks cap check requirement for SupportScreen Add tests for changes to SupportScreen Add tests for expected inline script data Add E2E tests to check if scanner is disabled if user has no capability Reduce `siteScanReducer` complexity Skip Site Scan if no validation nonce is provided Run ergebnis/composer-normalize Supply aspect-ratio to videos in Video Blocks Add height:auto to videos in Video blocks Use intrinsic layout for video instead of responsive Remove obsolete UserContextProvider from site-scan-notice after 473fdbd Omit updates nonce when user lacks install-themes cap anyway Limit access to validate_nonce to users who can amp_validate Limit access to SupportScreen to users who can amp_validate Add missing import for createInterpolateElement Improve translation strings ...
westonruter
changed the title
AMP_Validated_URL_Post_Type::get_url_from_post() instead of post_title property
westonruter
added
the
Changelogged
|
QA Passed ✅ The Validated URL is correct on the Support screen
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related #6707
Amend #6718
Checklist