Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Onboarding Wizard UI glitches #6742

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Fix Onboarding Wizard UI glitches #6742

merged 3 commits into from
Nov 30, 2021

Conversation

delawski
Copy link
Collaborator

Summary

Fixes #6740

Screenshot 2021-11-24 at 10 22 12

Changes:

  • Ensure falsy template mode details items are not rendered both in Onboarding Wizard and on AMP Settings screen.
  • Add spacing between footer nav buttons in Onboarding Wizard.
  • Extract common recommendation string about suppressed plugins to a new constant.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@delawski delawski added the Bug Something isn't working label Nov 24, 2021
@delawski delawski added this to the v2.2 milestone Nov 24, 2021
@delawski delawski self-assigned this Nov 24, 2021
@github-actions
Copy link
Contributor

Plugin builds for 520d8de are ready 🛎️!

@dhaval-parekh
Copy link
Collaborator

Changes look good to me.

@delawski delawski requested a review from westonruter November 24, 2021 09:49
@westonruter westonruter merged commit e683cf3 into develop Nov 30, 2021
@westonruter westonruter deleted the fix/6740-wizard-site-scan-ui-bugs branch November 30, 2021 05:20
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaval-parekh dhaval-parekh dhaval-parekh approved these changes

@westonruter westonruter Awaiting requested review from westonruter

Assignees

@delawski delawski

Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

Onboarding Wizard UI glitch.
3 participants
@delawski @dhaval-parekh @westonruter