Mark scripts output by wp_comment_form_unfiltered_html_nonce() and wp_post_preview_js() as being in AMP Dev Mode
#6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
fix/wp-comment-form-unfiltered-nonce-script
branch
from
62a6cb3 to
1916baf
Compare
|
Plugin builds for 2e498de are ready 🛎️!
|
westonruter
force-pushed
the
fix/wp-comment-form-unfiltered-nonce-script
branch
from
1916baf to
b282006
Compare
westonruter
changed the title
wp_comment_form_unfiltered_html_nonce() as being in AMP Dev Modewp_comment_form_unfiltered_html_nonce() and wp_post_preview_js() as being in AMP Dev Mode
westonruter
force-pushed
the
fix/wp-comment-form-unfiltered-nonce-script
branch
from
f5f25ee to
834724b
Compare
westonruter
commented
Nov 16, 2021
| remove_action( 'wp_head', 'wp_post_preview_js', 1 ); // @todo Instead of function, the script output by wp_post_preview_js() should get data-ampdevmode. | ||
| remove_action( 'wp_head', 'wp_oembed_add_host_js' ); // This is not needed when post embeds are embedded via <amp-wordpress-embed>. See <https://github.com/ampproject/amp-wp/issues/809>. | ||
| // This is not needed when post embeds are embedded via <amp-wordpress-embed>. See <https://github.com/ampproject/amp-wp/issues/809>. | ||
| remove_action( 'wp_head', 'wp_oembed_add_host_js' ); |
There was a problem hiding this comment.
This will be able to be removed in #6665
westonruter
force-pushed
the
fix/wp-comment-form-unfiltered-nonce-script
branch
from
834724b to
2e498de
Compare
|
QA passed Tested on post with comments form enabled, with Twenty Nineteen, Twenty Twenty and Twenty Twenty One themes - no validation errors encountered. |
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When in Transitional mode, I started seeing a validation error for the
scriptoutput bywp_comment_form_unfiltered_html_nonce(). This is a regression introduced by #6546, where thisscriptis exempted from validation but currently only in Standard mode and when Sandboxing is enabled. This PR ensures that the script is exempted for using Dev Mode when Sandboxing is not enabled.This also takes the same approach to no longer suppress the script output by
wp_post_preview_js()which is output when previewing a post.Checklist